Repository navigation
Fix JRuby in CI - #452
Merged
Merged
Fix JRuby in CI#452
Conversation
On JRuby, databases must be reached via JDBC URLs such as "jdbc:postgresql://localhost/app?user=postgres&password=secret". Parse the URL nested after "jdbc:", and read the user and password from query params when they are not in the userinfo (the PostgreSQL JDBC driver does not accept them there). Use JDBC URLs for the PostgreSQL and MySQL specs when running on JRuby. On JRuby, PostgreSQL also needs the hanami fix that checks for the jdbc-postgres gem (not jdbc-postgresql).
We added it so pry could load on Ruby 4.0, where readline is a bundled gem rather than a default gem. However, pry 0.16 now depends on reline primarily, we no longer need readline. Removing readline is helpful because it was interfering with the JRuby builds, where it installed by did not actually define the `Readline` class, which left pry with no input.
timriley
force-pushed
the
require-jruby-in-ci
branch
from
October 4, 2026 09:33
0d28fc5 to
02c0a5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.